LIMXTEC / BitSend

BitSend Master (Live Version)
http://www.bitsend.cc/
MIT License
43 stars 47 forks source link

undef BSD if present due to conflict with osx param.h macro #85

Closed grantHarris closed 6 years ago

grantHarris commented 6 years ago

RE: https://github.com/LIMXTEC/BitSend/issues/84

This PR fixes an issue with the QT code which causes the executable to fail to build on OSX.

In bitsendunits.h the enum Units value BSD conflicts with the OSX Dev SDK param.h file which has the macro

#define BSD 199506 /* System version (year & month). */

If we undef the BSD macro where the enum is used, the build succeeds.

limxdev commented 6 years ago

Frank work on it...

joshafest commented 6 years ago

If you change unit internally BSD to BsD .. it will work, I mean currency units ...

grantHarris commented 6 years ago

Ok, I'll change the enum value to BsD and remove the undefs. I should have another commit in a couple hours once I have a chance.

grantHarris commented 6 years ago

@joshafest See last commit

grantHarris commented 6 years ago

@limxdev Thanks! Address for the bounty. iDMJQsTgCdZLcKKREGA9wuTSBLdBtL5w1X

limxdev commented 6 years ago

Okay thank you