prune() race condition fix

LINBIT / drbdtop

CLI management tool for DRBD. Like top, but for DRBD resources.

GNU General Public License v2.0

48 stars 14 forks source link

prune() race condition fix #15

Closed raltnoeder closed 5 years ago

raltnoeder commented 5 years ago

This is supposed to be a better fix than the previously proposed one, since it avoids pruning events that have been updated by any of the 3 poll cycles before the current poll cycle (still provided that timestamps provided by drbdsetup make sense, and in the case where no events are seen, drbdtop's internal time reference isn't far ahead of drbdsetup's time).

rck commented 5 years ago

Sorry for forgetting about this one. If this is still an issue (I guess so), it would be great if you could:

rebase the patch on current "develop" branch
rewrite the commit msg. Yours is one very long line. Guess you forgot about the short one-liner?

Then just force push it to your ra/punefix2 branch and I will pick it up

raltnoeder commented 5 years ago

Alright, should be ready some time on Monday!

raltnoeder commented 5 years ago

Looks like I'm a bit slow... anyway, it should be ready now. ra/prunefix2 on my fork

rck commented 5 years ago

Thanks Robert, I merged and pushed it to origin/develop. Guess we can then release that very soon.