search

LINBIT / linstor-server

High Performance Software-Defined Block Storage for container, cloud and virtualisation. Fully integrated with Docker, Kubernetes, Openstack, Proxmox etc.
https://docs.linbit.com/docs/linstor-guide/
GNU General Public License v3.0
954 stars 76 forks source link

Snapshot creation during a sync results in inconsistent data #258

Closed chiraganand-e2e closed 2 years ago

chiraganand-e2e commented 3 years ago

If a resource is syncing on a node, say, after recovery and you take a snapshot of the resource then the snapshot created on this node which is not fully synced is not going to represent the exact state of the resource which is available on other nodes. That is, the data on the snapshot is going to be different on the still syncing node than other nodes.

Is this the intended behaviour?

raltnoeder commented 3 years ago

Certainly not intended, there is simply no check implemented for the state of the DRBD device before taking a snapshot. The data on a synchronizing node is inconsistent and therefore unusable. It would make sense for LINSTOR to refuse creating a snapshot on a node that has inconsistent data.

rp- commented 2 years ago

we added a check, so every resource needs to be UpToDate to create a snapshot