LINCHENYU2030S / pe

0 stars 0 forks source link

Documentation of Sort feature is not complete #3

Open LINCHENYU2030S opened 10 months ago

LINCHENYU2030S commented 10 months ago

For the sort feature, the user guide only states that sort /byphone will sort the person in ascending numerical order, but does not specify the sort /byphone sort the person in ascending numerical order of the FIRST NUMBER in each phone number. for example, phone number 111111 will be above phone number 222. Screenshot 2023-11-17 at 5.07.20 PM.png

nus-pe-script commented 10 months ago

Team's Response

It is stated in the UG that all sorting is done by "ASCII" sequence.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason] Screenshot 2023-11-21 at 6.50.44 PM.png

Screenshot 2023-11-21 at 7.02.50 PM.png

I still think that instead of just saying "The sorting is done in ASCII sequence" and leaving the user to learn how comparator involving ASCII sequence work, it is better to just state "The sorting is done in ascending numerical order of the FIRST NUMBER in each phone number", this will be much more straightforward for a user to understand. So I still consider this as an improvement under Explanations -> "The explanation is too brief".