LINNAE-project / SFB-Annotator

This web app is intended for demo purposes only!
https://www.research-software.nl/software/sfb-annotator
Apache License 2.0
1 stars 0 forks source link

Redundant input key/value pairs #56

Open arnikz opened 3 years ago

arnikz commented 3 years ago

@lisestork: The input fields seem redundant (differ only in case). Do you agree?

For example,

https://github.com/LINNAE-project/SFB-Annotator/blob/a79d9a5281fbe011fabc2121d115cc82193ff8c8/data/json/local/example_1_1.json#L3

https://github.com/LINNAE-project/SFB-Annotator/blob/a79d9a5281fbe011fabc2121d115cc82193ff8c8/data/json/local/example_1_1.json#L23

Query all example*.json files.

$ jq -r '[.text,.type]|@csv' data/json/local/*.json
"Taxon","taxon"
"Taxon","taxon"
"Taxon","taxon"
"person","person"
"Person","person"
"Person","person"
"Person","person"
"location","location"
"Location","location"
"measurementorfact","measurementorfact"
"measurementorfact","measurementorfact"
"propertyorattribute","propertyorattribute"
"propertyOrAttribute","propertyorattribute"
"anatomicalentity","anatomicalentity"
"anatomicalEntity","anatomicalentity"
"date","date"
"date","date"

Moreover, the RDFizer uses only the type field.

https://github.com/LINNAE-project/SFB-Annotator/blob/a79d9a5281fbe011fabc2121d115cc82193ff8c8/src/main/java/localdomain/localhost/servlets/writeAnnotationsToRDF.java#L71

lisestork commented 3 years ago

Yes indeed, I am not sure why the "text" is there, but "type" is the preferred field. Is it maybe from the field that is filled in automatically upon selection of a type? In any case, this information does not need to be present in the json file