LIST-LUXEMBOURG / iguess

iGuess 1.0 - The iGuess implementation in Rails
GNU General Public License v3.0
6 stars 0 forks source link

Validation #108

Open eykamp opened 10 years ago

eykamp commented 10 years ago

Add field validation for different simple datatypes when creating a modConfig.

uleopold commented 10 years ago

I do not understand this issue. Could you explain a bit more?

eykamp commented 10 years ago

When the datatype is specified as an integer, we should do some client-side (and perhaps server-side) validation to ensure that an integer has really been provided. We encountered a related problem in the training, when a user entered "12,3" for a floating point number, and the WPS process interpreted it as a list, and crashing happened. Validation would have prevented that problem.

Luckily, this is relatively easy to do.

uleopold commented 10 years ago

server side (WPS) to be done by Christian. Client side to be done by Luís or new person.

christianbraun commented 10 years ago

I was checking this issue: The checking is done by pyWPS already with the definition of the process inputs. With code in the module itself you can not sort this out, because pyWPS is already raising an exception (it is not crashing!). However this exception is not properly shown to the user in iGUESS. Maybe Luis and me need to see together how to adress this the most elegant way. For now I extended the abstract of the input...

uleopold commented 10 years ago

Christian, what is the status of this issue? Can this be solved soon in PyWPS?

christianbraun commented 10 years ago

There is no issue for PyWPS, it is working as expected. Like Chris said, it is up to the user interface

uleopold commented 10 years ago

Can we close it?

christianbraun commented 10 years ago

I don't think so...

uleopold commented 10 years ago

Luís can you take this over? I am not sure how difficult this is to implement into the user interface. Let me know if you see problems/difficulties.

uleopold commented 10 years ago

Any progress here?