search

LISTEN-moe / android-app

Official LISTEN.moe Android app
https://github.com/LISTEN-moe/android-app#download
MIT License
248 stars 25 forks source link

Play button doesn't get updated on click/status #11

Closed xTheEc0 closed 6 years ago

xTheEc0 commented 6 years ago

Please describe the problem you are having in as much detail as possible: Pressing the play button doesn't change the icon which lets to the misinterpretation of play state. Gently nudging the view (Locking, minimising, or just in-app movement as shown in the video) refreshes the view and updates the button.

~Video: https://puu.sh/AhFZr/e9330fa3d1.mp4~
Video: https://puu.sh/AibX1/8e5d7effab.mp4 Updated video using new version (slight volume warning). (This time not as horrible cropping, and with sound (since I thought it's needed to better explain whats happening) because I used 'Mobizen' instead of adb shell screenrecord)

Further details:

arkon commented 6 years ago

Any chance you can host the video somewhere else? It's taking forever to load for me.

Nevermind, I can see it now. I guess my Internet was particularly bad this morning.

Does this happen consistently for you? did it start happening recently if so?

xTheEc0 commented 6 years ago

Pretty consistent and I think it either always did that and I only really noticed it recently or started when I joined the beta recently. Can't recall sorry : (

xTheEc0 commented 6 years ago

Tested devices: (Can do even more : P ) image (The 'Device name' : 'Samsung' is Samsung S7 (Another one, not my personal), and 'Lge' is LG G5'. My scripts still need some polish to recognize everything : P )

Out of those only Vivo Xplay6 DIDN'T reproduce.
All other 5 reproduced.

EDIT: I actually may have more interesting info.
So on the device that doesn't repro I can see that pressing the button does somekind of turning/transform animation to change the state.
A lot of the time the devices that reproduce this have like one frame/degree of animation run and stop, so the issue could be in animation?

arkon commented 6 years ago

Does this happen on other devices that have >= Android 7.1? It's possible that this is happening because AnimatedVectorDrawable used to animate on the UI thread so it's super janky. If that's the case, I might just remove the animation for older versions of Android.