With the current implementation of window position restoring, you get unexpected behavior if either your X or Y position is right at the edge of your screen (i.e. 0).
Since the check whether a pre-set position exists (src/background.js#L33 and src/background.js#L34 in master, prior to this PR) use a Boolean check, they interpret a position of "0" as "There is no saved position" and thus use a null value.
This means that the window does not show up at the saved position, but in the center of the screen (at least from my tests).
To fix this I've set the default store values for the window position to [null, null] and instead made the BrowserWindow always use the store item values. The previous faulty Boolean check for these values is thus not needed any longer and the problem is solved.
PR is tested and works. Window position is properly restored for positions including 0 X/Y values and non-zero X/Y values.
With the current implementation of window position restoring, you get unexpected behavior if either your X or Y position is right at the edge of your screen (i.e. 0).
Since the check whether a pre-set position exists (
src/background.js#L33andsrc/background.js#L34in master, prior to this PR) use a Boolean check, they interpret a position of "0" as "There is no saved position" and thus use a null value.This means that the window does not show up at the saved position, but in the center of the screen (at least from my tests).
To fix this I've set the default store values for the window position to
[null, null]and instead made the BrowserWindow always use the store item values. The previous faulty Boolean check for these values is thus not needed any longer and the problem is solved.PR is tested and works. Window position is properly restored for positions including 0 X/Y values and non-zero X/Y values.