search

LIT-EIA / adapt-esdc-accessibilityfixes

Extension to load and run a .js file when a course loads
GNU General Public License v3.0
5 stars 2 forks source link

Components - Slideshow/Narrative - Should be controllable with keyboard #103

Closed GGD4V closed 3 years ago

GGD4V commented 3 years ago

Issue: The slideshow widget under "What Being Privileged Does NOT Mean" should have multiple ways to be controlled. We should be able to change slides with our keyboard arrows instead of dealing with tab forward click, tab back click...

LIT-EIA-OWNER commented 3 years ago

Add code to control it with Keyboard

See how WET or W3C made their caroussel?

GGD4V commented 3 years ago

Already works with keyboard on tab and enter press. W3C example does not give a carousel requiring keyboard arrows, hence not an immediate requirement.

https://www.w3.org/WAI/tutorials/carousels/working-example/

GGD4V commented 3 years ago

Another w3c sample that doesn't seem to require arrow keys functions. https://www.w3.org/TR/wai-aria-practices-1.1/examples/carousel/carousel-1.html

MaximPerry commented 3 years ago

Arrow keys control is more of a "should" than a "must". What's really important here is that the carousel is keyboard accessible and intuitive. In those two example, they are:

https://www.w3.org/TR/wai-aria-practices-1.1/examples/carousel/carousel-1.html https://www.w3.org/WAI/tutorials/carousels/working-example/

Tab forward + space / enter = next slide, and tab back + space / enter = previous slide. You can see the visual focus indicator just fin, and the carousel controls are usable using only the keyboard. in Adapt however, it's not so obvious how to access the carousel controls. When my focus is on "next slide", I intuitively hit Shift Tab to select the "previous slide" button but my focus gets lost elsewhere. Or after I successfully changed the slide, my focus is else where, no longer on the "Next slide" button...

GGD4V commented 3 years ago

was fixed here. https://github.com/MeD-DMC/Adapt-accessibilityfixes/commit/8e62b1ac253591ccd7a62e41811bbfc124d0e3cb

Should now be more intuitive when focus returns to either the arrow button that was used or the one that is not narrative-hidden for a similar experience than carousel given by W3C.