search

LIT-EIA / adapt-esdc-accessibilityfixes

Extension to load and run a .js file when a course loads
GNU General Public License v3.0
5 stars 2 forks source link

Component - Narrative - role & aria-level #122

Closed falcochip closed 2 years ago

falcochip commented 2 years ago

2.3 MeD: Page contains Heading “0” (1.3.1)  Narrative component has role="heading" then adding an aria-level = 0 Recommendation = "We recommend replacing all with an H3 heading. "

Not exactly a heading so maybe set role = "note"/"widget"

falcochip commented 2 years ago

2.2 MeD: Narrative - aria-valid-attr-value (4.1.1, 4.1.2)  2.10 MeD: aria-valid-attr-value (2.1.1)  see screenshot ARIA attributes must have valid values.

Path

.narrative-content-item.visited[data-index="\33 "] > .narrative-content-title > .narrative-content-title-inner[aria-level="\30 "][role="heading"] Snippet

<div class="narrative-content-title-inner" role="heading" aria-level="0"> What should you do? </div>

dunno where the path is coming from - not in JS

Might be because aria-level="0" is invalid for role="heading"

TimbroVince commented 2 years ago

Header needs to stay since there is both header and content, so let's have it update header level automatically.

We need to talk to Melissa about this one, should we allow using a narrative with a header but NO content