search

LIT-EIA / adapt-esdc-accessibilityfixes

Extension to load and run a .js file when a course loads
GNU General Public License v3.0
5 stars 2 forks source link

Using tabindex to create a tab order that does not preserve meaning and operability #96

Closed GGD4V closed 3 years ago

GGD4V commented 3 years ago

Issue: A focus order is being forced using tabindex="" with positive values. This prevent the natural focus order the page should have. For example, it skips the "Skip to main content" link and the top navigation, making them irrelevant. How to fix: Instead of using tabindex="" with positive values, make sure the "Skip to main content" link is the first element to get in focus by putting as the fist focus-able element in the DOM (which it already is?) and that all the other focus-able elements are in order in the DOM as well. If there's something you don't which to get in focus, you can use tabindex="-1" as long as it makes sense.

GGD4V commented 3 years ago

Confirmed skip on first tab in Safari. Should fix.

Code is inside GlobalFixes, under comment "//Tab order of buttons in the top navigation bar"

TimbroVince commented 3 years ago

Code started, see comment //GitHub error 96

TimbroVince commented 3 years ago

See pull request https://github.com/MeD-DMC/Adapt-accessibilityfixes/pull/110