Refactors executeWithRetry to no longer block but rather poll the executeCallback for its completion which allows the Timeout to successfully invoke and short circuit operations.
Reduces the default retry attempts from 3 to 1
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Added new unit tests to misc.spec.ts for exercising different retry situations that where not covered.
Used local testing
command to test: DEBUG=false NETWORK=manzano yarn test:local --filter=testDelegatingCapacityCreditsNFTToAnotherWalletToExecuteJs
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
Description
executeWithRetry
to no longer block but rather poll theexecuteCallback
for its completion which allows the Timeout to successfully invoke and short circuit operations.3
to1
Type of change
How Has This Been Tested?
misc.spec.ts
for exercising different retry situations that where not covered.command to test:
DEBUG=false NETWORK=manzano yarn test:local --filter=testDelegatingCapacityCreditsNFTToAnotherWalletToExecuteJs
Checklist: