Closed MaximusHaximus closed 5 days ago
The local-tests/tests/testImportWrappedKey.ts test is importing a Solana key but says the keyType
is K256
This test also isn't really testing if the key was imported correctly, but I think we'd have to use either getEncryptedKeyMetadata
or the sign methods to verify it was
Are there tests for getEncryptedKeyMetadata
and storeEncryptedKeyMetadata
?
Are there tests for
getEncryptedKeyMetadata
andstoreEncryptedKeyMetadata
?
Not directly; they are used by all of the other tests, so are extensively tested alreeady
Addressed feedback and responded to some questions with questions @DashKash54 :)
Description
keyType
andpublicKey
keys to the persisted metadata, and requires they are provided when consumers call the methods that require themlit-actions-client
contains all code specific to interacting with the lit actions,service-client
contains all of the same for interactions with the wrapped keys backend, andapi
contains definitions of all top-level API methods that will be exposed to the consumer of the packageindex.ts
rather than blanket exporting everything in the package with * exports. The goal here is to facilitate us being able to modify the LIT action APIs without making breaking changes to the top-level API methods that consumers are using as we need to.customXXXX
methods, in favour of us instead add a basic documentation blurb to the JSDocs for prospective integrators that shows them how easy it is to get the private key metadata from the wrapped keys service, and then submit it to any custom LIT action, using the LitNodeClient instance that they already have in scope. Thecustom
behaviour in the SDK exposes internals of LIT actions to our consumer API, and would cause us to get tickets against the wrapped-keys SDK that are actually issues with custom LIT Action implementations on top of making the API worse for consumers of the package who want to use 'supported' networks.e.g.:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: