search

LJMUAstroecology / flirpy

Python library to interact with FLIR camera cores
Other
191 stars 54 forks source link

Forgot to actually change the file. #41

Closed helarsen closed 1 year ago

helarsen commented 3 years ago

there is a memory leak in the find_camera.cpp in get_id() function. There is a return statement inside the while loop which bypass the release() of the resources.

jveitchmichaelis commented 3 years ago

Do you want to add this to your other PR?

helarsen commented 3 years ago

No reason to bother with the memory leak issue if the subsequent PR (returning of all video devices) is accepted as it completely replaces find_cameras.exe I used it partly as a test ride to create a pull request. That said, the memory leak is hardly ever going to be a real issue in practice - but correct - is correct.