search

LJMUAstroecology / flirpy

Python library to interact with FLIR camera cores
Other
184 stars 54 forks source link

AGC modes added #79

Closed litscham closed 1 year ago

litscham commented 1 year ago

I added commands to get and set AGC mode for Boson

jveitchmichaelis commented 1 year ago

Thanks! Would it be possible to add tests that check if the mode is set correctly for each of the options? (Rather than simply testing for a non-empty return) I'd be happy to merge once that's done.

For example see test_ffc_mode_auto, we'd have a separate test for each one.

jveitchmichaelis commented 1 year ago

@litscham I added some review notes - unfortunately I don't have a Boson to test with at the moment so if you could implement the tests on your end and check they run, that'd be great and I'll merge it.

litscham commented 1 year ago

I'll check it out once I have the time

litscham commented 1 year ago

I tested on different firmware revs and the option to set and get AGC only worked on the newest 3.0.25868 firmware

jveitchmichaelis commented 1 year ago

Great. I guess we could add a check for the firmware revision (e.g. via get_firmware_revision)? It's a bit awkward to check each time, but changing AGC mode is probably done rarely enough that it wouldn't matter for performance.