search

LJOSC / checkmark-backend

CheckMark Backend: The Backbone of Task Tracking
Other
5 stars 11 forks source link

Project structure setup #3

Closed HarshDobariya79 closed 3 months ago

HarshDobariya79 commented 3 months ago

This PR closes #2

vishvamsinh28 commented 3 months ago

Looks good to me but it would be good to have a types folder

HarshDobariya79 commented 3 months ago

Looks Good!! I think an ApiResponse file might further help in maintaining consistency.

Yes, that's correct 💯

HarshDobariya79 commented 3 months ago

Looks good to me but it would be good to have a types folder

I forgot to add a .gitkeep file to preserve empty directories. I'll add that.

HarshDobariya79 commented 3 months ago

@vishvamsinh28 @kushal-lalwani I've pushed the requested changes. Please check at your convenience.

h3110Fr13nd commented 3 months ago

Do you think we should be adding dockerfile from the beginning. Making it container first approach? Or should We create a new issue for that?

HarshDobariya79 commented 3 months ago

Do you think we should be adding dockerfile from the beginning. Making it container first approach? Or should We create a new issue for that?

Let's create a new issue to make things more organised.

h3110Fr13nd commented 3 months ago

Do you think we should be adding dockerfile from the beginning. Making it container first approach? Or should We create a new issue for that?

Let's create a new issue to make things more organised.

Created a new Issue to add dockerfile

4