search

LJOSC / checkmark-backend

CheckMark Backend: The Backbone of Task Tracking
Other
5 stars 11 forks source link

Added A Docker File #7

Closed het4399 closed 5 months ago

het4399 commented 5 months ago

This PR closes #4

HarshDobariya79 commented 5 months ago

Moreover since we're using mongodb, maybe add a db service of mongo in compose.yaml.

I think we don't need the mongodb service for the production since we're using Mongo Atlas. For the development or testing, we might need that. If there is any way to create a mongodb service only for the dev, it'l help.

HarshDobariya79 commented 5 months ago

@het4399 Thank you for this PR. One thing I would like to suggest is to keep only the comments that are strongly needed in the dockerfiles. For the reference you can see the link present in the issue description.

HarshDobariya79 commented 5 months ago

@h3110Fr13nd Can you please review this PR and guide @het4399?

HarshDobariya79 commented 5 months ago

@het4399 Can you complete this issue before next Thursday? Because many people wants to contribute but due to the lack of dockerfile for mongodb, there's a setup overhead. By adding a dockerfile to run a mongodb container quickly will reduce the setup overhead and result in better productivity.

het4399 commented 5 months ago

@het4399 Can you complete this issue before next Thursday? Because many people wants to contribute but due to the lack of dockerfile for mongodb, there's a setup overhead. By adding a dockerfile to run a mongodb container quickly will reduce the setup overhead and result in better productivity.

I Will complete it by tomorrow eod.

het4399 commented 5 months ago

@HarshDobariya79 @h3110Fr13nd ,Hey ,i need help, After adding the mongodb ,i am not able to hit my server ,but instance of mongodb is working.Can you help me out