search

LJPc-solutions / freescout-calendar-module

A calendar module for Freescout
20 stars 7 forks source link

module not working after FreeScout update #36

Closed Maddmax76 closed 1 year ago

Maddmax76 commented 1 year ago

hi, this morning we applied the FreeScout 1.8.103 update, since then the LJPcCalendar module no longer shows anything, it doesn't draw the calendar, it doesn't show the list of available calendars.

There are no errors in the logs.

You can help us?

Maddmax76 commented 1 year ago

I think it's a problem with translation management....

Uncaught ReferenceError: translations is not defined at order (calendar-dashboard.js:78:55) at Object.success (calendar-dashboard.js:101:17) at u (46140893f1434a057f8c17ccff19c4e091573413939.js:1:27541) at Object.fireWith [as resolveWith] (46140893f1434a057f8c17ccff19c4e091573413939.js:1:28286) at k (46140893f1434a057f8c17ccff19c4e091573413939.js:1:77735) at XMLHttpRequest. (46140893f1434a057f8c17ccff19c4e091573413939.js:1:79991) order @ calendar-dashboard.js:78 success @ calendar-dashboard.js:101 u @ 46140893f1434a057f8c17ccff19c4e091573413939.js:1 fireWith @ 46140893f1434a057f8c17ccff19c4e091573413939.js:1 k @ 46140893f1434a057f8c17ccff19c4e091573413939.js:1 (anonymous) @ 46140893f1434a057f8c17ccff19c4e091573413939.js:1 load (async) send @ 46140893f1434a057f8c17ccff19c4e091573413939.js:1 ajax @ 46140893f1434a057f8c17ccff19c4e091573413939.js:1 showItems @ calendar-dashboard.js:93 (anonymous) @ calendar-dashboard.js:117 e @ jquery-3.6.0.min.js:2 t @ jquery-3.6.0.min.js:2 setTimeout (async) (anonymous) @ jquery-3.6.0.min.js:2 c @ jquery-3.6.0.min.js:2 fireWith @ jquery-3.6.0.min.js:2 fire @ jquery-3.6.0.min.js:2 c @ jquery-3.6.0.min.js:2 fireWith @ jquery-3.6.0.min.js:2 ready @ jquery-3.6.0.min.js:2 B @ jquery-3.6.0.min.js:2

Maddmax76 commented 1 year ago

Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' 'nonce-NUbO7FUJVFxYIlFbVqIUPzPPp'". Either the 'unsafe-inline' keyword, a hash ('sha256-uOuigLQo0fpXdTq2haKWyn1c2n6hhF+6oiF/9KBfqJs='), or a nonce ('nonce-...') is required to enable inline execution.

Lars- commented 1 year ago

I noticed the same thing. When I have the time, I will look into it. If you manage to fix it yourself in the meantime, please submit a pull request.

Maddmax76 commented 1 year ago

I found this while googling, I hope it helps:

"Your CSP is blocking an inline event handler in your HTML code, like .

Inline event handlers are bad practice (mostly because they are inline). See this answer for insight.

Nonce does not seem to work with inline event handlers though. So the best thing to do would be to replace this event handler with a proper one written in your JS file. If you cannot do that, try adding 'unsafe-hashes' to your script-src.

Kudos for rejecting 'unsafe-inline', it's a shortcut we see way too often, including in production."

Lars- commented 1 year ago

Fixed in the latest release

Maddmax76 commented 1 year ago

perfect, installed now, started working again. A thousand thanks!

Maddmax76 commented 1 year ago

hi, sorry if I reopen the report, but the "add to calendar" icon inside a ticket doesn't work, viewing the console it seems like it's the same problem as the inline script.

Also in the calendar there are problems with overlapping days when creating all-day tasks on contiguous days. If I create an appointment, for example, for Monday 6th and Tuesday 7th and then another for Wednesday 8th and Thursday 9th, when I save you see the calendar correctly, then after about ten seconds the page updates and the appointment that goes from '8 to 9, takes the start date 7, in the calendar you can see the activity stretching over days 7, 8 and 9. To solve this we need to uncheck all day and enter the manual start and end times.

Furthermore, by changing the times of an appointment created for the 15th from 8:00 to 19:30, after a few seconds the activity in the calendar moves from 7:00 to 18:30, as if there were problems with the calculation of the time daylight saving time and standard time, or with the time zone.

Are you also experiencing these problems?

I understand that I have posted many confusing reports. They are available for clarification.

thanks!