LJXSean / pe

0 stars 0 forks source link

Overzealous input validation for name of supplier #6

Open LJXSean opened 1 year ago

LJXSean commented 1 year ago
  1. Attempt to add a supplier of name: Amy's Pet House
  2. Error message thrown and input blocked.

image.png

A pet supplier's name might use the " ' " symbol. This hinders operation of software and causes inconvinience to the user. This may happen relatively often but users can still use the product

nus-se-bot commented 1 year ago

Team's Response

Hi,

Thank you for your suggestion. We accept this as a bug.

However, we think that this bug should be of low severity because not too many pet suppliers' names contain special characters. Our target users's suppliers will be mainly individuals whose names are more like "Amy Smith", "Bernice Yu", "Ben Hong" etc. Therefore, the normal usage is highly unlikely to be affected.

This is a duplicate of another issue because they are all about overzealous input validation on names.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Valid name value shows invalid

Step to reproduce : Adding new deliverer with S/O in his name

Expected : Adds the new deliverer

Actual : Gives error message for name

Screenshot 2022-11-11 at 4.26.26 PM.png


[original: nus-cs2103-AY2223S1/pe-interim#3371] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi,

Thank you for your suggestion. We accept this.

However, we think it is more of a feature flaw than of a functionality bug. If you go to our module website here, you can see the explanation about "overzealous input validation", which is exactly what you pointed out. As per the website, this is a feature flaw.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]