search

LKDevelopment / hetzner-cloud-php-sdk

A PHP SDK for the Hetzner Cloud API
MIT License
104 stars 51 forks source link

Keep Hetzner's snake_case for properties #75

Closed ThomasLandauer closed 2 years ago

ThomasLandauer commented 3 years ago

Don't you think it would be easier to just keep the properties as they're coming, to be compatible with https://docs.hetzner.cloud/#servers-get-a-server ?

LKaemmerling commented 3 years ago

Hey @ThomasLandauer,

yep this is easier but would be a breaking change which I wouldn't like to do.

ThomasLandauer commented 3 years ago

I just wanted to hear what you say in general ;-) My plan about the BC break would be to add the snake case properties (like I did it now). And @deprecate the others. And then, in some future version (3?), remove them.

LKaemmerling commented 3 years ago

I just wanted to hear what you say in general ;-) My plan about the BC break would be to add the snake case properties (like I did it now). And @deprecate the others. And then, in some future version (3?), remove them.

Hey @ThomasLandauer,

yep this is fine for me :)

ThomasLandauer commented 3 years ago

Done :-)