search

LKDevelopment / hetzner-cloud-php-sdk

A PHP SDK for the Hetzner Cloud API
MIT License
104 stars 51 forks source link

fixes nullable port #81

Closed jprangenbergde closed 2 years ago

jprangenbergde commented 2 years ago

If you created a ICMP Rule, the port is nullable.

This change fixes: _TypeError: LKDev\HetznerCloud\Models\Firewalls\FirewallRule::_construct(): Argument #5 ($port) must be of type string, null given, called in /var/www/html/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/Firewalls/Firewall.php on line 112 and defined in /var/www/html/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/Firewalls/FirewallRule.php:48

image image

jprangenbergde commented 2 years ago

@LKaemmerling: What do you say to this PR?

LKaemmerling commented 2 years ago

Hey @jprangenbergde,

thank you for the fix! Good catch!