search

LKM-code-base / RotatingMHD

GNU General Public License v3.0
1 stars 0 forks source link

Magnetic induction solver #156

Open j507 opened 3 years ago

j507 commented 3 years ago

The pull-request introduces the classes

through a series of smaller pull-request as roughly outlined by the project "Magnetic induction solver". MagneticInduction is to be validated through convergence tests. Subsequently, NavierStokesProjection is to be expanded to consider the magnetohydrodynamic problem, which is also to be verified with convergence tests.

sebglane commented 2 years ago

@j507 Could you let me know what the steps would be on this branch?

j507 commented 2 years ago

@j507 Could you let me know what the steps would be on this branch?

The merged pull-request #172 was not done. It is meant to introduce a base MagneticInductionProblem<dim> class. It would be the realization of your idea to have problem specific classes, in which the setup of the problem becomes boiler plate code and the user only has to change the boundary conditions, post-processing and the input mesh.

sebglane commented 2 years ago

The merged pull-request #172 was not done. It is meant to introduce a base MagneticInductionProblem<dim> class. It would be the realization of your idea to have problem specific classes, in which the setup of the problem becomes boiler plate code and the user only has to change the boundary conditions, post-processing and the input mesh.

Does that mean that I should continue the development on magnetic_induction_problem_class or should I revert merging #172?

j507 commented 2 years ago

The merged pull-request #172 was not done. It is meant to introduce a base MagneticInductionProblem<dim> class. It would be the realization of your idea to have problem specific classes, in which the setup of the problem becomes boiler plate code and the user only has to change the boundary conditions, post-processing and the input mesh.

Does that mean that I should continue the development on magnetic_induction_problem_class or should I revert merging #172?

Either is a possibility. Either revert and continue working on that branch or create a new branch in which the objectives of magnetic_induction_problem_class are then achieved.

Another objective that I had forgotten to add is that a Problem class implies another Parameter structure for the specific problem type.