search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Allow adding custom cli args #103

Closed evanlinjin closed 1 year ago

evanlinjin commented 1 year ago

Also added Args::cp_limit.

codecov-commenter commented 1 year ago

Codecov Report

Merging #103 (8e93959) into master (aabec1b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   51.32%   51.32%           
=======================================
  Files           9        9           
  Lines         602      602           
=======================================
  Hits          309      309           
  Misses        293      293

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LLFourn commented 1 year ago

ACK though in practice I think we should not put rpc args at the top level. The rpc args should be put on the actual command that uses them. Otherwise, It strongly implies to someone that every command needs these arguments.

evanlinjin commented 1 year ago

ACK though in practice I think we should not put rpc args at the top level. The rpc args should be put on the actual command that uses them. Otherwise, It strongly implies to someone that every command needs these arguments.

What do you mean by RPC Args?

LLFourn commented 1 year ago

@evanlinjin I mean that it should be an argument to the subcommand only.

evanlinjin commented 1 year ago

As discussed with @LLFourn, I am convinced that chain_args is not needed. However, cp_limit will still be helpful.