Closed LLFourn closed 1 year ago
Merging #111 (2507988) into master (b7d12e6) will increase coverage by
8.06%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 51.32% 59.39% +8.06%
==========================================
Files 9 8 -1
Lines 602 266 -336
==========================================
- Hits 309 158 -151
+ Misses 293 108 -185
Impacted Files | Coverage Δ | |
---|---|---|
bdk_chain/src/chain_data.rs | 48.64% <ø> (ø) |
|
bdk_chain/src/chain_graph.rs | 0.00% <ø> (ø) |
|
bdk_chain/src/descriptor_ext.rs | 0.00% <ø> (ø) |
|
bdk_chain/src/keychain.rs | 0.00% <ø> (ø) |
|
bdk_chain/src/keychain/keychain_txout_index.rs | 0.00% <ø> (ø) |
|
bdk_chain/src/lib.rs | 100.00% <ø> (ø) |
|
bdk_chain/src/tx_graph.rs | 64.23% <ø> (ø) |
|
bdk_chain/src/sparse_chain.rs | 78.57% <100.00%> (ø) |
|
bdk_coin_select/src/bnb.rs | ||
bdk_coin_select/src/coin_selector.rs | ||
... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@evanlinjin I think we should merge this now and turn your points into an issue. It's important we rebase stuff ontop of this ASAP I think.
@evanlinjin I think we should merge this now and turn your points into an issue. It's important we rebase stuff ontop of this ASAP I think.
Sure, no problem!
Task list
bdk_core
andbdk_keychain
modulesbdk_core
intobdk_chain
bdk_cli::Args::cp_limit
(checkpoint limit) so that block-by-block syncing does not eat memoryKeychainTxOutIndex::store_all_up_to
logicKeychainTxOutIndex::pad_with_unused
methods - necessary for block-by-block syncingNote: We will merge this as is an continue work in a separate PR. This way, we can rebase changes.