search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Put bdk_file_store into bdk_chain #114

Closed LLFourn closed 1 year ago

LLFourn commented 1 year ago

It only needs std and bincode v2.0.0. We can make bincode an optional dependency as I think implementing bincode traits directly would be a nice addition anyway.

The only thing I can see that we need to do is get rid of anyhow from bdk_file_persist (just return an std::io::Error) and to actually implement the bincode traits on everything. Some things might have to be done without derive since we might want to use consensus encode/decode for various bitcoin types.

evanlinjin commented 1 year ago

I think it would be best to use bincode via serde for now, as bitcoin types do not implement bincode::{Decode, Encode} and will take some time to impl them for our structures.

LLFourn commented 1 year ago

Fixed by #115