search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Put `bdk_file_store` into `bdk_chain` #115

Closed evanlinjin closed 1 year ago

evanlinjin commented 1 year ago

Partially completes #114

Not done

~Currently, the file_store feature requires serde. The future plan would be to implement bincode::{Encode, Decode} on our types so we only need to depend on bincode for persistance.~

Because of the complexity and inconvenience of maintaining manual bincode implementations, and if we use bincode(use_serde), we would require the serde dependency anyhow, it will be better to just depend on serde.

codecov-commenter commented 1 year ago

Codecov Report

Merging #115 (5488e41) into master (b6a9886) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   59.39%   59.39%           
=======================================
  Files           8        8           
  Lines         266      266           
=======================================
  Hits          158      158           
  Misses        108      108
Impacted Files Coverage Δ
bdk_chain/src/lib.rs 100.00% <ø> (ø)
bdk_chain/src/sparse_chain.rs 78.57% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.