search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Make TxGraph::calculate_fee return 0 for coinbase #121

Closed LLFourn closed 1 year ago

LLFourn commented 1 year ago

And fix a panic. Arguable this should return a negative value but I've left the API the same for now.

codecov-commenter commented 1 year ago

Codecov Report

Merging #121 (acef29b) into master (fbc88da) will increase coverage by 4.78%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   59.39%   64.17%   +4.78%     
==========================================
  Files           8        8              
  Lines         266      268       +2     
==========================================
+ Hits          158      172      +14     
+ Misses        108       96      -12
Impacted Files Coverage Δ
bdk_chain/src/tx_graph.rs 73.38% <100.00%> (+9.14%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

evanlinjin commented 1 year ago

@LLFourn Do you think it makes sense to make all values be i64?