search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

ChainGraph::apply_changeset should not allow changesets with conflicts #135

Closed LLFourn closed 1 year ago

LLFourn commented 1 year ago

With #134 I made the chaingraph check that whatever is applied within the changeset does not conflict with its existing transactions. But this does not check that the changeset does not have transactions that conflict with itself. I added an ignored test for this in #134 https://github.com/LLFourn/bdk_core_staging/pull/134/files#diff-9b84a64dce9e6adeb1e74cadf3ca65487cb6748e0e55112755cc9a91a4c27877R419

LLFourn commented 1 year ago

@evanlinjin decided that this is a wontfix for now. We're taking the direction that changsets should just be blindly applied without checks for the time being.