search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

`TxGraph` descendants #138

Closed evanlinjin closed 1 year ago

evanlinjin commented 1 year ago

This PR currently implements:

codecov-commenter commented 1 year ago

Codecov Report

Merging #138 (7160424) into master (e6a3755) will increase coverage by 0.27%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   64.81%   65.09%   +0.27%     
==========================================
  Files           9        9              
  Lines         378      381       +3     
==========================================
+ Hits          245      248       +3     
  Misses        133      133
Impacted Files Coverage Δ
bdk_chain/src/chain_graph.rs 81.81% <ø> (ø)
bdk_chain/src/tx_graph.rs 83.76% <100.00%> (+0.32%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LLFourn commented 1 year ago

So the point of this is to fix some things in #120 like evicting children of an evicted tx right. Cool. Before merging we should make the algorithm non-recursive because rust doesn't support tail call optimization yet I think.