search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Inflate_changeset must not produce a changeset that has conflicts #139

Closed LLFourn closed 1 year ago

LLFourn commented 1 year ago

When creating its changeset inflate_changeset checks for conflicts with its local chain but doesn't not check for conflicts within the changeset that it is inflating. This allows it to create a contradictory changeset which it should not do.

evanlinjin commented 1 year ago

One way to do this is to use an internal TxGraph and we add changeset transactions one by one and check for conflicts with each add.

LLFourn commented 1 year ago

This is already done. It doesn't do descendants eviction but that's a problem everywhere.

evanlinjin commented 1 year ago

This is already done. It doesn't do descendants eviction but that's a problem everywhere.

138 will change that! :wink: