LLFourn commented 1 year ago

We need to be able to open a file without loading it yet.

Added is_empty methods on some types that I didn't end up using but kept them because it seemed helpful.

Removed the caching of derivation indices within the store because it wasn't really doing it's job with the cli example and we should do this properly on the outside.

codecov-commenter commented 1 year ago

Codecov Report

Merging #142 (ded648d) into master (7c95cf2) will increase coverage by 1.58%. The diff coverage is 68.33%.

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   63.26%   64.85%   +1.58%     
==========================================
  Files           8        9       +1     
  Lines         294      367      +73     
==========================================
+ Hits          186      238      +52     
- Misses        108      129      +21

Impacted Files	Coverage Δ
bdk_chain/src/file_store.rs	`0.00% <0.00%> (ø)`
bdk_chain/src/sparse_chain.rs	`77.77% <50.00%> (-2.72%)`	:arrow_down:
bdk_chain/src/tx_graph.rs	`81.45% <57.14%> (-1.19%)`	:arrow_down:
bdk_chain/src/keychain.rs	`54.54% <93.75%> (+54.54%)`	:arrow_up:
bdk_chain/src/chain_graph.rs	`81.81% <100.00%> (+81.81%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LLFourn commented 1 year ago

I just rebased on master and cleaned up some stuff from #132. I removed the missing check from apply changeset since we agreed that we should either check all aspects of validity before applying a changeset or none of them.

LLFourn / bdk_core_staging

Improve file store ergonomics #142

Codecov Report