search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

[Alternate] Methods that change derivation indicies should return changesets #154

Closed rajarshimaitra closed 1 year ago

rajarshimaitra commented 1 year ago

This is a parallel of #150 . I have approached the changes as discussed in the PR thread.

Fixes #151

Added more Docs.

Todo: More tests. I am already working on them. Will push soon.

Opened for early comments.

codecov-commenter commented 1 year ago

Codecov Report

Merging #154 (e596ffc) into master (e6a3755) will increase coverage by 0.54%. The diff coverage is 93.75%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   64.81%   65.36%   +0.54%     
==========================================
  Files           9        9              
  Lines         378      384       +6     
==========================================
+ Hits          245      251       +6     
  Misses        133      133
Impacted Files Coverage Δ
bdk_chain/src/file_store.rs 18.18% <ø> (ø)
bdk_chain/src/keychain/keychain_txout_index.rs 0.00% <0.00%> (ø)
bdk_chain/src/keychain.rs 56.89% <100.00%> (+2.35%) :arrow_up:
bdk_chain/src/chain_graph.rs 81.81% <0.00%> (ø)
bdk_chain/src/tx_graph.rs 83.76% <0.00%> (+0.32%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rajarshimaitra commented 1 year ago

Added test coverage for the new APIs. Commented out the test cases at numeric bound as naturally, that will gulp up all the rams.. Still included for documentation purposes.

@evanlinjin @LLFourn, this I think is now ready for a look..

evanlinjin commented 1 year ago

@rajarshimaitra I did a fixup to the documentation, and implemented a fix for store_up_to (as it panicked when up_to was greater than derivation bounds).

LLFourn commented 1 year ago

I made #159 and now don't have time to do the apply_additions method. If anyone wants to finish that for me go ahead otherwise I'll try and get to it later.

evanlinjin commented 1 year ago

I made #159 and now don't have time to do the apply_additions method. If anyone wants to finish that for me go ahead otherwise I'll try and get to it later.

Attempted in #160