LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Implement `KeychainTxOutIndex::apply_additions` #160

Closed evanlinjin closed 1 year ago

evanlinjin commented 1 year ago

Internally, this just uses store_all_up_to, however this will change once we start storing a "lookahead" index for each keychain.

Additionally, I have removed AsRef and AsMut implementations for DerivationAdditions, and DerivationAdditions now has a single field last_derived.


This is my attempt at addressing https://github.com/LLFourn/bdk_core_staging/pull/154#issuecomment-1411479890

codecov-commenter commented 1 year ago

Codecov Report

Merging #160 (f846d7b) into mark-and-unmark-used (8438e30) will decrease coverage by 0.26%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                    @@
##           mark-and-unmark-used     #160      +/-   ##
========================================================
- Coverage                 65.89%   65.64%   -0.26%     
========================================================
  Files                         9        9              
  Lines                       390      390              
========================================================
- Hits                        257      256       -1     
- Misses                      133      134       +1     
Impacted Files Coverage Δ
bdk_chain/src/keychain/keychain_txout_index.rs 0.00% <ø> (ø)
bdk_chain/src/keychain.rs 61.19% <100.00%> (-1.50%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LLFourn commented 1 year ago

Internally, this just uses store_all_up_to, however this will change once we start storing a "lookahead" index for each keychain.

I imagine that we will delete store_all_up_to and apply_additions will just take all its logic.

LLFourn commented 1 year ago

Can you make this PR to #154 instead?

LLFourn commented 1 year ago

I merged this into #154 already