search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Add KeychainTxOutIndex::reserve_next_unused_spk #188 #194

Closed LagginTimes closed 1 year ago

LagginTimes commented 1 year ago

Fixes #188 Second method will be done later this week.

LLFourn commented 1 year ago

LGTM! I think I still like this approach over the alternative which is to return an owned Script from next_unused_spk.

codecov-commenter commented 1 year ago

Codecov Report

Merging #194 (d183b9d) into master (250b4f1) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files           9        9           
  Lines         230      230           
=======================================
  Hits          139      139           
  Misses         91       91

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

evanlinjin commented 1 year ago

LGTM as well. I was talking to @LLFourn about this PR today and he suggested to add tests for these added methods. Let me know if you need some direction for this :)