evanlinjin commented 1 year ago

Most of this code is copied from the work in https://github.com/bitcoindevkit/bdk/pull/793

@LLFourn mentioned that it makes sense to put the persist module as part of the bdk_chain package.

Note that this is based on the work done in #191 and #196

codecov-commenter commented 1 year ago

Codecov Report

Merging #204 (20b340e) into master (3b26714) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files           9        9           
  Lines         230      230           
=======================================
  Hits          139      139           
  Misses         91       91

Impacted Files	Coverage Δ
bdk_chain/src/chain_graph.rs	`81.81% <ø> (ø)`
bdk_chain/src/keychain.rs	`56.89% <ø> (ø)`
bdk_chain/src/sparse_chain.rs	`77.77% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LLFourn commented 1 year ago

Can we squash this down to one commit and base it on master?

LLFourn commented 1 year ago

closed in favor of #206

LLFourn / bdk_core_staging

Keychain persist #204

Codecov Report