search

LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Add persistance with example database #64

Closed vladimirfomene closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #64 (824b022) into persist-linked-list (001831b) will not change coverage. The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           persist-linked-list      #64   +/-   ##
====================================================
  Coverage                60.98%   60.98%           
====================================================
  Files                       11       11           
  Lines                     1374     1374           
====================================================
  Hits                       838      838           
  Misses                     536      536
Impacted Files Coverage Δ
bdk_core/src/lib.rs 25.92% <ø> (ø)
bdk_core/src/byte_list.rs 89.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vladimirfomene commented 1 year ago

@LLFourn, I have updated as recommended and finished implementing the sync functionality. Couldn't get the first test to pass, it is timing for some reason? I believe it is become of the number of file i/o that the proptest is trying to do.

LLFourn commented 1 year ago

I changed the PR's base to master. There will be a lot of conflicts as we go but we might as well use this PR to do all the changes.

evanlinjin commented 1 year ago

I'm going to create a separate PR to have the ChangeSet-related changes only.

vladimirfomene commented 1 year ago

Hi @LLFourn ! I have updated the PR as recommended. I was wondering if you can help me resolve the conflicts, I'm finding it hard to tell in some cases which is suppose to be most recent code.

vladimirfomene commented 1 year ago

Better implementation merged in #67