LLFourn / bdk_core_staging

Staging area for bdk_core initial development
15 stars 12 forks source link

Tests for mempool consistency #76

Closed LLFourn closed 1 year ago

LLFourn commented 1 year ago

We merged #74 but didn't really add any tests to properly enforce the new behaviors.

The main thing I can see is missing is testing that a transaction that was in a stale block which conflicts with an update transaction does not make it into the mempool.

I think #74 also introduced a bug where an update can evict a transaction in the chain without invalidating its block by having a new transaction that conflicts with it. We shouldn't allow this and this should mean the update is invalid. Test for this too.