search

LLFourn / secp256kfun

A pure-rust secp256k1 library optimised for fun
BSD Zero Clause License
100 stars 28 forks source link

Add clippy and resolve suggestions #147

Closed nickfarrow closed 1 year ago

nickfarrow commented 1 year ago

Small clippy fixes and also removed the pointless sid_len from the derive_nonce_rng! that doesn't add any collision resistance. Though this will break consistency of deterministic nonce rngs between releases.

Prior to this fixup, the &&s have just been getting fully dereferenced right? Like

Scalar::from_hash(hash.add(R).add(X).add(&&Message))
LLFourn commented 1 year ago

Cool. Thanks. can you add clippy to CI so we can finally close #32.

nickfarrow commented 1 year ago

I noticed only a few uppercase acronyms (https://github.com/LLFourn/secp256kfun/issues/31)

type DLEQ = Eq<$mod::DLG<$len>, $mod::DL<$len>>;

Currently i have left them as clippy allowed

LLFourn commented 1 year ago

Thanks so much for this!