search

LLNL / ATS

ATS - Automated Testing System - is an open-source, Python-based tool for automating the running of tests of an application across a broad range of high performance computers.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Adding jsrun_np_max option #115

Closed MishaZakharchanka closed 1 year ago

MishaZakharchanka commented 1 year ago

Adds options that are similar to the existing jsrun_np and lsrun_np options, but with additional logic to only override the np set for tests if the np is larger than the number provided to these options. This way tests that are meant to run on less processors than specified aren't moved to higher counts.t

This PR will close: https://github.com/LLNL/ATS/issues/94

MishaZakharchanka commented 1 year ago

Would like to do more testing. I'll move this out of a Draft after said testing is done.

dawson6 commented 1 year ago

HIt an error with testing, trace is here. NoneType and int mismatch

File "/usr/apps/ats/7.0.dawson/lib/python3.8/site-packages/ats/management.py", line 890, in core self.run(interactiveTests) File "/usr/apps/ats/7.0.dawson/lib/python3.8/site-packages/ats/management.py", line 1016, in run unfinished = machine.scheduler.step() File "/usr/apps/ats/7.0.dawson/lib/python3.8/site-packages/ats/schedulers.py", line 81, in step result = machine.startRun(nextTest) File "/usr/apps/ats/7.0.dawson/lib/python3.8/site-packages/ats/machines.py", line 680, in startRun return self.launch(test) File "/usr/apps/ats/7.0.dawson/lib/python3.8/site-packages/ats/machines.py", line 350, in launch test.commandList = self.calculateCommandList(test) File "/usr/apps/ats/7.0.dawson/lib/python3.8/site-packages/ats/atsMachines/lsf_asq.py", line 335, in calculateCommandList if test.blueos_np_max > 0 and test.np > test.blueos_np_max: TypeError: '>' not supported between instances of 'NoneType' and 'int'

dawson6 commented 1 year ago

BTW, the test scenario is likely one where the np_max option was not specified on the command line

MishaZakharchanka commented 1 year ago

@dawson6 if you could run a few tests on this it would be much appreciated. The few tests that I have seem to be working but they aren't very extensive. Seems to be working with Kripke.

dawson6 commented 1 year ago

Will do, testing again\

dawson6 commented 1 year ago

OK, I am awake today, and this all looks good. going to merge it for you @MishaZakharchanka