search

LLNL / ATS

ATS - Automated Testing System - is an open-source, Python-based tool for automating the running of tests of an application across a broad range of high performance computers.
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Swapping results from management main to return 0 on success and 1 on error #130

Closed dawson6 closed 1 year ago

dawson6 commented 1 year ago

redoing merge request with changes

dawson6 commented 1 year ago

Very confused, my checkout of this shows '0' but the MR 'diffs' shows False still.

dawson6 commented 1 year ago

hang on, may not have pushed <doh!>

dawson6 commented 1 year ago

ok, fixed, I thought I had pushed my update, but it was uncommitted. So committed, rebased, and pushed again,

white238 commented 1 year ago

Alternate suggestion:

ATSManager.main() could continue to return True on success and False on failure

then change:

https://github.com/LLNL/ATS/blob/main/ats/__main__.py to return 0 on manager.main() success and 1 otherwise

This would allow downstream users who wrap ATSManager to check for success based on the boolean but the ultimate command line return code would follow standards.

I glanced over all the scripts in ats/tools and because they are all calling into the ats script then it would also cover those cases as well.