search

LLNL / ATS

ATS - Automated Testing System - is an open-source, Python-based tool for automating the running of tests of an application across a broad range of high performance computers.
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Update Warnings/Errors to have consistent prefixes #21

Closed white238 closed 1 year ago

white238 commented 3 years ago

Having a consistent prefix for logging messages across ATS is helpful when searching logs. Something like:

"ERROR: " "WARNING: "

MishaZakharchanka commented 1 year ago

@dawson6 Do we want to have "ATS" as a prefix to our printed and logged statements? Is it a common problem to have many error or warning messages that are mixed from different codes and it isn't clear who/what is causing the issue?

Based on Chris' suggestion the statements can be fairly simple, so maybe there isn't much confusion between codes and log/print messages.

We also have raise/except AtsError, should that be used in some way so that we aren't printing and logging Error by hand?

dawson6 commented 1 year ago

I think standardizing on ATS as the prefix for messages sounds fine.

dawson6 commented 1 year ago

@MishaZakharchanka has addressed this with a MR.