LLNL / ATS

ATS - Automated Testing System - is an open-source, Python-based tool for automating the running of tests of an application across a broad range of high performance computers.
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

fix faulty AtsTest comparisons #65

Closed davidbloss closed 2 years ago

davidbloss commented 2 years ago

ATS tests were being scheduled out of order due to how two AtsTest instances were being compared.

Line 644 in ats/management.py was erroneously checking for tests not in a list based on the test's "totalPriority" attribute. Two tests with the same "totalPriority" would be considered equivalent. Unlike "totalPriority", a test's "serialNumber" attribute is unique and should have been referenced from the beginning. ATS instructs some tests to wait until a list of other tests have completed before beginning. This list of dependent tests was incomplete and this update fixes this sneaky problem.