Closed vsurjadidjaja closed 11 months ago
Thanks for the PR @vsurjadidjaja !
I've noticed a few things:
FindLDMS.cmake
file? It's missing in the PRprintf
in the code. It works like Log(0).stream() << "log message\n"
. The number indicates the log level, where 0 is a critical error, 1 is informational, and 2 is debug level. You won't see level 1 and 2 output unless you set the CALI_LOG_VERBOSITY
environment variable to 1 or 2, respectively.Hi @daboehme!!
Thank you for taking a looking at my PR. I've rebased my fork to upstream/main. Please let me know if that's correct. I've also changed all messages to Caliper's logging format. To resolve the change I made in cali-query's CMakeLists.txt, I added two env variables in the README that instructs users to set the LD_LIBRARY_PATH and PATH so that Caliper can find LDMS's lib, bin, and sbin based on where the user installs LDMS.
Hi @vsurjadidjaja , thanks again for the PR! I fixed a few things in the top-level CMakeLists.txt that were still somehow reverting some changes in the main branch, but otherwise it looks good to me! I'll merge it in. I'll try to find a machine with LDMS here where I can give this a spin.
Adding the LDMS connector/forwarder and all necessary support files.