search

LLNL / Caliper

Caliper is an instrumentation and performance profiling library
http://software.llnl.gov/Caliper/
BSD 3-Clause "New" or "Revised" License
344 stars 63 forks source link

Question about timer resolution increasing #530

Open alkino opened 7 months ago

alkino commented 7 months ago

In this commit: https://github.com/LLNL/Caliper/commit/8605c925f6cdd0f3ca46b0d8c398236ae0296f23#diff-954e57c109f5357a835754e303d3cf1d914d61dbbb2642d5d7d0b5ba1f46f119

The timer resolution have been increased. It seems that since this patch we need to add .ns to time.offset, time.duration and time.inclusive.duration.

This is not explicitly said in the Release message and there is still the previous way in the doc.

Did I miss something?

daboehme commented 7 months ago

Hi @alkino, yes with the timer resolution increase we added a .ns to some of the internal time attribute names like time.offset and time.duration. This is handled transparently in the built-in config recipes like hatchet-region-profile, however if you're manually configuring Caliper with the CALI_SERVICES_ENABLE etc. variables and use cali-query to process the output you might need to make these adjustments. Apologies for the inconvenience!

Good point about the documentation though, I'll check and fix instances where I may have missed this.

alkino commented 7 months ago

I will add something new here: https://github.com/LLNL/Caliper/pull/458

Would be good to modify the release note here: https://github.com/LLNL/Caliper/releases/tag/v2.10.0

To tell the breakage for both of those features