LLNL / Elemental

Distributed-memory, arbitrary-precision, dense and sparse-direct linear algebra, conic optimization, and lattice reduction
Other
65 stars 16 forks source link

Project fails to reconfigure with '-DHydrogen_ENABLE_TESTING=ON' #140

Closed yurivict closed 1 year ago

yurivict commented 1 year ago

I first build with -DHydrogen_ENABLE_TESTING=OFF - it succeeds. Then I reconfigure it with ```-DHydrogen_ENABLE_TESTING=ON in order to build and run tests. This fails:

===>  Testing for hydrogen-linear-algebra-1.5.1.29
fatal: ambiguous argument 'hydrogen': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
-- Using __restrict__ keyword.
-- Found LAPACK: /usr/local/lib/libopenblas.so;-lpthread;-lm;-ldl
-- Using BLAS with trailing underscore.
-- Using LAPACK with trailing underscore.
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING

Most cmake-based projects are able to reconfigure with tests and run tests after build then.

It also isn't clear what make target runs tests. The README doesn't say anything about this.

benson31 commented 1 year ago

I'm not able to reproduce this.

$ ninja
[167/167] Creating library symlink libHydrogen_CXX.so
$ cmake -DHydrogen_ENABLE_TESTING=ON ..
-- Found Aluminum@1.0.0: /path/to/aluminum/lib64/cmake/aluminum
-- Aluminum detected with NCCL2 backend support.
-- Aluminum detected with HostTransfer backend support.
-- Using __restrict__ keyword.
-- Found LAPACK: /usr/lib64/liblapack.so;/usr/lib64/libblas.so
-- Using BLAS with trailing underscore.
-- Using LAPACK with trailing underscore.
-- Configuring done
-- Generating done
-- Build files have been written to: /path/to/hydrogen-clean/build
$  ninja
[44/44] Linking CXX executable tests/Gemm_Suite

The tests are not well-maintained vis-a-vis the CMake integration. In particular, they might hang and/or not run at all. But the target is test (the default for CTest) if you want to try.

yurivict commented 1 year ago

Tests build fine now - some scripting errors were to blame.

Thank you for your help.