search

LLNL / ExaCMech

BSD 3-Clause "New" or "Revised" License
17 stars 0 forks source link

Rename DEBUG directive causing issues #2

Closed rcarson3 closed 4 years ago

rcarson3 commented 4 years ago

In a few places, a preprocessor directive defined as DEBUG is being used. We only use this for debugging purposes, and it turns out that if we want to have those code paths turned on in other libraries we might run into issues. I ran into this within ExaConstit when trying to take advantage of MFEMv4.1 and make use of a debug build where the DEBUG directive is made use of. MFEM makes use of an enum with a DEBUG named field which is causing issues with this debug directive being passed into the compiler for ExaConstit. Therefore, I say we rename DEBUG to something like ECMECH_DEBUG.

Thoughts @nrbarton ?

rcarson3 commented 4 years ago

Fixed in e383903a9790ed583c7a94858e3e2bb152ef9e92