search

LLNL / GridDyn

GridDyn is an open-source power transmission simulation software package
Other
45 stars 23 forks source link

GridDyn autobuild on Windows #35

Closed nightlark closed 6 years ago

nightlark commented 6 years ago

Both AUTOBUILD_SuiteSparse and AUTOBUILD_KLU need to be given to GridDyn to make SuiteSparse get autobuilt (AUTOBUILD_SuiteSparse didn't show up in the list of options with the initial configuration on Windows). Is the behavior of needing to provide both of these options intended?

nightlark commented 6 years ago

Some context, I let autobuild create the dependencies in a release configuration on Windows, and then created a fresh build folder with CMAKE_PREFIX_PATH set to the libs folder in the previous build directory. The previously built copy of zlib and minizip don't get detected (it autobuilds them again).

Minizip also has an error on Windows, probably caused by CMAKE_BUILD_TYPE not being set.

CMake Error at config/cmake/buildMiniZip.cmake:6 (if):
  if given arguments:

    "IN_LIST" "valid_btypes"

  Unknown arguments specified
Call Stack (most recent call first):
  src/utilities/CMakeLists.txt:104 (build_minizip)
mcneish1 commented 6 years ago

I'm in favor of dropping one or the other. Think I'd prefer keeping AUTOBUILDKLU and adding AUTOBUILD* for other parts of SuiteSparse as needed.

phlptp commented 6 years ago

I think we should drop one, but KLU pretty much needs most of suitesparse so I am not sure which one to drop

phlptp commented 6 years ago

Can you check with the latest commit?

nightlark commented 6 years ago

That feels a lot smoother getting suitesparse/klu autobuilt as the default behavior. The minizip error is also gone.