search

LLNL / GridDyn

GridDyn is an open-source power transmission simulation software package
Other
46 stars 23 forks source link

Fix code coverage testing #46

Closed mcneish1 closed 5 years ago

mcneish1 commented 5 years ago

Fix #45

I'm not sure how to trigger the code coverage test, I don't think it normally happens for pull requests

phlptp commented 5 years ago

that seems to have broken the builds, @nightlark would know how to trigger a coverage build

phlptp commented 5 years ago

@nightlark will have to answer that question

phlptp commented 5 years ago

I would like @nightlark to take a look at it and make sure, but I will probably merge this before tonight to see if the coverage runs properly overnight.

nightlark commented 5 years ago

The easy way to trigger all of the cron builds like coverage for a branch with changes is to add a new cron job for the branch with the changes on https://travis-ci.org/LLNL/GridDyn/settings -- it takes a minute or so to trigger the build, after which the cron job can be removed. The other way is triggering a build on the Travis dashboard and giving it a modified version of the travis yaml file with the condition for the coverage build changed.

mcneish1 commented 5 years ago

https://travis-ci.org/LLNL/GridDyn/jobs/458143922 is failing because https://codecov.io/bash is down. The coveralls submission worked.

I'm going to fix lcov-helper.sh to check if the codecov download succeeded, then this should be good to go.

phlptp commented 5 years ago

let me know when you are happy with it.

mcneish1 commented 5 years ago

Should be good to go