search

LLNL / GridDyn

GridDyn is an open-source power transmission simulation software package
Other
45 stars 23 forks source link

units rework #47

Closed mcneish1 closed 4 years ago

mcneish1 commented 5 years ago

This PR switches GridDyn over to the new units implementation.

phlptp commented 5 years ago

Should we make a new branch in the GridDyn Repo to merge this until we get it all working, that might be simpler than doing it in the cmake_updates branch

mcneish1 commented 5 years ago

Should we make a new branch in the GridDyn Repo to merge this until we get it all working, that might be simpler than doing it in the cmake_updates branch

This is a new branch. It's targeting cmake_updates because that's the most up-to-date one

phlptp commented 5 years ago

I don't want to merge into cmake_update until the tests pass on travis, and I don't think that is possible while the repo is private

mcneish1 commented 5 years ago

What's the hurry merging this into anything? I don't understand the purpose of merging this into a different temporary branch pre-cmake_update.

mcneish1 commented 4 years ago

Merged into helics_updates