search

LLNL / H5Z-ZFP

A registered ZFP compression plugin for HDF5
Other
50 stars 22 forks source link

Tests: (fix) Small improvements and Github actions #109

Closed jwsblokland closed 1 year ago

jwsblokland commented 1 year ago
jwsblokland commented 1 year ago

@brtnfld I made some additional changes based on the recently created feat-cmake_tests branch. Now it supports building using Microsoft Visual Studio properly. One thing that still puzzled me is that when I ran a test via the command it works while if I use ctest it fails. It reports a missing DLL. I have no clue which DLL is missing. Maybe it is ctest itself that misses a DLL.

brtnfld commented 1 year ago

Was the skipped test due to the DLL issues (and will be enabled when fixed), or something fundamental?

jwsblokland commented 1 year ago

I am not completely sure which skipped tests you are taking about. For now, I assume you mean the certain tests that has been excluded for Microsoft Visual Studio. These tests have been excluded because they make use of a bash script. If one could create a Windows equivalent batch script these is no need to exclude them anymore. Unfortunately, my batch skills are very limited therefore I decided to exclude the tests for now.

Actually, in general these tests needs to be improved or extended because they do not fully capture all the equivalent tests of the auto-tools build systems. I consider this a first step in a possible replacement of the autotools build system. Of course it is up to @markcmiller86 and/or you whether to drop this autobuild system or not. Having said that it is good to see the CMake build system has already value today. For example, H5Z-ZFP can now be properly build on a Windows system. It was not my original intent of contributing the CMake build system but it is a very nice bonus of switching to CMake.

brtnfld commented 1 year ago

Yes, I meant the Windows skipped tests in Windows.

Thanks, I'll go ahead and merge this and add a task list to the issue so that we get an idea of what done looks like.

Agreed, it would help to switch to Cmake instead of Autotools for spack.